-
Notifications
You must be signed in to change notification settings - Fork 307
fix(dropdown,tooltip):Fix the saas theme #3384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
## Walkthrough
This update adjusts font size and line height styles for tooltip and dropdown components. It modifies the tooltip popper's line height by increasing it slightly, reduces font sizes in dropdown items and tooltips on small screens by changing Tailwind utility classes. No logic or control flow changes are involved.
## Changes
| Files/Groups | Change Summary |
|------------------------------------------------------------------------------|----------------------------------------------------------------------------------------------------|
| packages/theme-saas/src/tooltip/index.less | Increased `.tooltip__popper` line height from `leading-5` to `leading-5.5` for vertical spacing. |
| packages/vue/src/dropdown-item/src/mobile-first.vue | Changed dropdown level container class from `'text-sm'` to `'text-xs'` for smaller font size. |
| packages/vue/src/tooltip/src/token.ts | Updated `classes.tooltip` to use `sm:text-xs` instead of `sm:text-sm` for small screen font sizing.|
## Poem
> A hop, a skip, a font so small,
> Tooltips and dropdowns heed the call.
> From leading lines to pixels true,
> Responsive tweaks for a fresher view.
> With every nibble, styles align—
> A rabbit’s work, both neat and fine!
> 🐇✨ Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
packages/vue/src/dropdown-item/src/mobile-first.vueOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. packages/vue/src/tooltip/src/token.tsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
PR
fix:修复saas主题
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit